Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use better_html 2.1.0 #995

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Don't use better_html 2.1.0 #995

merged 1 commit into from
Mar 19, 2024

Conversation

etiennebarrie
Copy link
Member

Fix #993

@etiennebarrie etiennebarrie mentioned this pull request Mar 18, 2024
Closed
@D-system
Copy link
Contributor

I use a different approach in the CSV PR with that commit ef2bfb3
The advantage is that still allow Rails 6.1+ to use the latest better_html version.

@etiennebarrie
Copy link
Member Author

etiennebarrie commented Mar 19, 2024 •
edited
Loading

Yes it's just temporary, we need to fix it in better_html. Edit: this should be fixed by Shopify/better-html#130

@etiennebarrie etiennebarrie merged commit 6c71af4 into main Mar 19, 2024
41 checks passed
@etiennebarrie etiennebarrie deleted the prevent-better_html-2.1.0 branch March 19, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvasilevski nvasilevski nvasilevski approved these changes

@D-system D-system D-system approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weekly CI run failed
3 participants
@etiennebarrie @D-system @nvasilevski