Avoid loading Rails or ActiveSupport in tests #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vinistock any thoughts? |
andyw8
force-pushed
the
andyw8/use-minitest
branch
from
4a88962 to
78f45b1
Compare
andyw8
force-pushed
the
andyw8/use-minitest
branch
from
553d5c2 to
cbc1e25
Compare
vinistock
reviewed
Nov 6, 2024
|
|
||
| require "test_helper" | ||
|
|
||
| require_relative "../test/dummy/config/environment" |
There was a problem hiding this comment.
I think this is the key culprit here. I don't even think we need to switch fully to just Minitest.
As long as we require only the parts of Active Support related to testing, we can continue with the same setup.
But we can't load the dummy app for every test because that will load everything and get us into trouble.
| t.test_files = ["test/ruby_lsp_rails/server_test.rb"] | ||
| end | ||
|
|
||
| task default: [:"db:setup", :test, "test:server"] |
There was a problem hiding this comment.
Did you test if adding a present? in the add-on code breaks when running bundle exec rake?
I think because test:server is last, then the related test helper only gets required at the end, but I'm not 100% sure.
Suggested change
| task default: [:"db:setup", :test, "test:server"] | |
| task default: ["db:setup", :test, "test:server"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent issues such as #509 we can switch to using
Minitest::Testinstead ofActiveSupport::TestCasefor the test files.I have temporarily added the
test_declarativegem to avoid editing all the test declarations, but if we decide to go ahead then I can do that.We have one test file (
server_test.rb) that does need to load Rails so I have split that out.There is currently one failing test that I need to look into.fixed