Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract test helper method wait_for_rails_to_boot #545

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Dec 12, 2024

With #526 we'll have this in 3 places, so let's extract it to something more readable.

(fyi @ChallaHalla)

@andyw8 andyw8 added the chore Chore task label Dec 12, 2024
@andyw8 andyw8 requested a review from a team as a code owner December 12, 2024 21:08
@andyw8 andyw8 changed the title Extract testhelper wait_for_rails_to_boot Extract test helper method wait_for_rails_to_boot Dec 12, 2024
@vinistock
Copy link
Member

Instead of sleeping, can we instead extract this one to a shared method and reuse it everywhere?

It's a bit more elegant because it forces the threads to block until activation is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants