Skip to content

Commit

Permalink
Merge pull request #1942 from Shopify/ba-fix-arr-all
Browse files Browse the repository at this point in the history
Fix ActiveRecordRelations compiler to dedup #all
  • Loading branch information
bitwise-aiden authored Jun 27, 2024
2 parents 3854808 + 321345b commit df961ec
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/tapioca/dsl/compilers/active_record_relations.rb
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ def gather_constants
# Grab all Spawn methods
query_methods |= ActiveRecord::SpawnMethods.instance_methods(false)
# Remove the ones we know are private API
query_methods -= [:arel, :build_subquery, :construct_join_dependency, :extensions, :spawn]
query_methods -= [:all, :arel, :build_subquery, :construct_join_dependency, :extensions, :spawn]
# Remove "group" which needs a custom return type for GroupChains
query_methods -= [:group]
# Remove "where" which needs a custom return type for WhereChains
Expand Down

0 comments on commit df961ec

Please sign in to comment.