Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for add-on #2108

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add integration tests for add-on #2108

wants to merge 2 commits into from

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Dec 3, 2024 •
edited
Loading

Closes https://github.com/Shopify/team-ruby-dx/issues/1327

This PR adds an integration test for the flow of generating DSL RBIs for a particular compiler.

I chose to use the ActiveJob compiler to avoid any database complexity.

I've tried to reduce the Rails files to the minimum possible.

@andyw8 andyw8 force-pushed the andyw8/add-test-app branch 2 times, most recently from 731b94a to 1272fc7 Compare December 5, 2024 19:54
@andyw8 andyw8 added the chore label Dec 5, 2024
@andyw8 andyw8 force-pushed the andyw8/add-test-app branch 2 times, most recently from 13e7fb1 to c430822 Compare December 10, 2024 17:04
andyw8
andyw8 commented Dec 10, 2024
View reviewed changes
spec/tapioca/addon_spec.rb Outdated Show resolved Hide resolved
andyw8
andyw8 commented Dec 10, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@andyw8 andyw8 force-pushed the andyw8/add-test-app branch 3 times, most recently from 1341238 to f73556c Compare December 16, 2024 16:58
@andyw8 andyw8 changed the title WIP: Add integration tests for addon Add integration tests for addon Dec 16, 2024
andyw8
andyw8 commented Dec 16, 2024
View reviewed changes
spec/tapioca/addon_spec.rb Outdated Show resolved Hide resolved
@andyw8 andyw8 changed the title Add integration tests for addon Add integration tests for add-on Dec 16, 2024
@andyw8 andyw8 marked this pull request as ready for review December 16, 2024 17:18
@andyw8 andyw8 requested a review from a team as a code owner December 16, 2024 17:18
@andyw8 andyw8 requested a review from KaanOzkan December 16, 2024 17:18
@andyw8
Copy link
Contributor Author

andyw8 commented Dec 17, 2024

Looking into the test failures, seems unrelated to this PR though:

    it compile RBIs with location from gem source                   FAIL (1.20s)
        --- expected
        +++ actual
        @@ -1,66 +1,66 @@
        -"# source://the-default-gem//lib/bar.rb#1
        +"# source://the-default-gem/lib/bar.rb#1

@andyw8 andyw8 force-pushed the andyw8/add-test-app branch from ac043a9 to 7cfa93a Compare December 17, 2024 19:08
@andyw8 andyw8 mentioned this pull request Dec 17, 2024
Closed
andyw8
andyw8 commented Dec 17, 2024
View reviewed changes
spec/addon_spec_helper.rb

module ActiveSupport
class TestCase
def pop_result(server)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from ruby-lsp-rail's test suite, but we may be able to remove: Shopify/ruby-lsp-rails#548

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd be nice.

KaanOzkan
KaanOzkan reviewed Dec 17, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
spec/addon_spec_helper.rb

module ActiveSupport
class TestCase
def pop_result(server)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'd be nice.

spec/addon_spec_helper.rb Outdated Show resolved Hide resolved
spec/tapioca/addon_spec.rb Outdated Show resolved Hide resolved
spec/tapioca/addon_spec.rb Outdated Show resolved Hide resolved
spec/tapioca/addon_spec.rb Show resolved Hide resolved
KaanOzkan
KaanOzkan reviewed Dec 18, 2024
View reviewed changes
spec/tapioca/addon_spec.rb Outdated Show resolved Hide resolved
spec/tapioca/addon_spec.rb Show resolved Hide resolved
@andyw8
Copy link
Contributor Author

andyw8 commented Dec 18, 2024 •
edited
Loading

(I will squash before merging).
DONE

@andyw8 andyw8 force-pushed the andyw8/add-test-app branch from 30963aa to 9cfb25c Compare December 19, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaanOzkan KaanOzkan KaanOzkan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyw8 @KaanOzkan