Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support schema presets block type completion #663

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aswamy
Copy link
Contributor

@aswamy aswamy commented Dec 10, 2024

What are you adding in this PR?

Fixes #628

Add support for completion of presets block type.

  • Look at the blocks section (whether it be locally-defined blocks or block references) to auto-complete block types in the preset area
  • Preset blocks can be nested, so we need to fetch block files and read its schema to determine what to auto-complete

Testing

  • Checkout Shopify/dawn
  • Find a section where it has section blocks defined under schema
  • In preset, add a blocks and see if type gets auto-completed by whatever is in blocks section

(see all edge cases in the ticket)

What's next? Any followup issues?

#624

Before you deploy

  • I included a minor bump changeset
  • My feature is backward compatible

@aswamy aswamy requested review from charlespwd and a team December 10, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme block type (preset) completion
1 participant