Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RightToLeft Obfuscation - PowerShell #5072

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FilipPwn
Copy link

@FilipPwn FilipPwn commented Nov 6, 2024

Summary of the Pull Request

Added a new detection rule for identifying PowerShell scripts that use RightToLeft obfuscation techniques to evade detection.

Changelog

new: RightToLeft Obfuscation - PowerShell - Detects obfuscated PowerShell scripts using RightToLeft method for evasion.

Example Log Event

N/A

Fixed Issues

N/A

SigmaHQ Rule Creation Conventions

  • If your PR adds new rules, please consider following and applying these conventions

@github-actions github-actions bot added Rules Windows Pull request add/update windows related rules labels Nov 6, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @FilipPwn 👋

It looks like this is your first pull request on the Sigma rules repository!

Please make sure to read the SigmaHQ conventions document to make sure your contribution is adhering to best practices and has all the necessary elements in place for a successful approval.

Thanks again, and welcome to the Sigma community! 😃

@nasbench
Copy link
Member

nasbench commented Nov 7, 2024

Hey @FilipPwn and thanks for the contribution. In order for this to be a detection you need to add a bit more context. As simply specifying the string "RightToLeft" isn't enough. You're only hunting for potentially interesting scripts. Hence either add additional context with more strings or move this to the threat hunting folder.

Also your description is lacking a lot of the context. This technique is relying on the regex option of the "Matches" method. So please include that in both the description and enhance the title to reflect that as this isn't detecting a generic RTLO technique but rather a specific powershell implementation of it.

@nasbench nasbench marked this pull request as draft November 7, 2024 17:47
@nasbench nasbench added Work In Progress Some changes are needed Author Input Required changes the require information from original author of the rules labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author Input Required changes the require information from original author of the rules Rules Windows Pull request add/update windows related rules Work In Progress Some changes are needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants