Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post planning should receive and return a dict #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

winglian
Copy link

@Apollyon81
Copy link

It was not clear what this is for and how to apply it.

@@ -90,14 +90,14 @@ def can_handle_post_planning(self) -> bool:
return False

@abc.abstractmethod
def post_planning(self, response: str) -> str:
def post_planning(self, response: Dict[Any, Any]) -> Dict[Any, Any]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dict[Any, Any] is equivalent to Dict, but it can be made more specific:

Suggested change
def post_planning(self, response: Dict[Any, Any]) -> Dict[Any, Any]:
def post_planning(self, response: Dict[str, Any]) -> Dict[str, Any]:

Same for the other 2 instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants