Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply kerning table offset to correct glyph. #405

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Updates the library to apply the kerning offset provided by the KERN table against the correct glyph.

Note. This is a breaking change. The semantics for several public methods were incorrect and required updating.

Copy link
Member

@tocsoft tocsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

I doubt the breaking change would really impact anyone anyway and that particular API might not even be fully fit for purpose in all fonts either as its only giving the kern table kernings and not the gpos ones (which theoretically should be the same, but there nothing stopping them being different)

@JimBobSquarePants
Copy link
Member Author

@tocsoft Thanks for the quick review! I agree regarding the API. I remember someone asking for it, but I don't think it's all that useful.

@JimBobSquarePants JimBobSquarePants merged commit a47bb5d into main Jun 28, 2024
29 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/fix-kerning branch June 28, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants