Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use Ceil when measuring. #418

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Don't use Ceil when measuring. #418

merged 2 commits into from
Oct 28, 2024

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Measuring should preserve accuracy and not ceil to the nearest whole pixel.

@JimBobSquarePants JimBobSquarePants merged commit 43b97c4 into main Oct 28, 2024
8 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/fix-measurements branch October 28, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JimBobSquarePants