Fix vertical alignment of non-vertical glyphs #435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
When I removed the offsetting of vertical glyphs during #432 I forgot about non-vertical glyphs. This PR reintroduces the behavior in a more correct manner.
Note. It's really hard to write unit tests for this stuff. I think we need to introduce some regression tests in the form of image comparison using ImageSharp.Drawing to render the result.
Rendered output