Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align font outline and fill while calling DrawText #331

Merged
merged 3 commits into from
May 10, 2024

Conversation

tocsoft
Copy link
Member

@tocsoft tocsoft commented May 10, 2024

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

fixes the outline being offset from the fill.
Required the outline being moved (thickness/2) pixels up and left.

before

image

after

image

fixes #330

@tocsoft tocsoft requested a review from JimBobSquarePants May 10, 2024 15:33
@tocsoft tocsoft force-pushed the issue330-offset-outline branch from 298d848 to 16d10c4 Compare May 10, 2024 15:42
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks for this!

@JimBobSquarePants JimBobSquarePants merged commit db32b13 into main May 10, 2024
8 checks passed
@JimBobSquarePants JimBobSquarePants deleted the issue330-offset-outline branch May 10, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pen and brush not aligned in DrawText
2 participants