Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent greenhouse from rendering in main building loop #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sketchy502
Copy link
Owner

In 1.5 green houses are classified as a regular building, which was causing them to be rendered twice.

This PR should now handle greenhouse correctly, including their location on the farm, however, there may be some artifacts at the initial greenhouse location due to how we are generating the farm base image.

@Sketchy502 Sketchy502 requested a review from Laukei February 2, 2021 19:24
Copy link
Collaborator

@Laukei Laukei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change seems okay. Is there an example of the output? Does this work with farm renders from plans? Have you tested it on the default maps? What happens for versions less than 1.5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants