Fix loop block label update bug

[wintonzheng]

Important

Fixes label update bug in getUpdatedNodesAfterLabelUpdateForParameterKeys by correcting loopVariableReference update logic in workflowEditorUtils.ts.

• Bug Fix:
  • Fixes label update bug in getUpdatedNodesAfterLabelUpdateForParameterKeys in workflowEditorUtils.ts.
  • Corrects loopVariableReference update logic to match new label if it matches old label's output parameter key.

^{This description was created by for af92eab. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Incremental review on af92eab in 36 seconds

More details

• Looked at 19 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:1197

• Draft comment:
  Consider refactoring the repeated logic for updating the label to improve maintainability and reduce redundancy. This logic appears in multiple places, such as lines 1197 and 1209.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR description indicates a fix for updating loopVariableReference when the label changes. The code correctly updates loopVariableReference if it matches the old label's output parameter key. However, the logic for updating the label itself is repeated in multiple places, which could be refactored for clarity and maintainability.

Workflow ID: wflow_JDzCUaYeZvZ4W7oc

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to af92eab in 52 seconds

More details

• Looked at 19 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:1199

• Draft comment:
  Consider updating loopValue similarly to loopVariableReference if it depends on the label.

loopValue:
  node.data.loopValue === getOutputParameterKey(oldLabel)
    ? getOutputParameterKey(newLabel)
    : node.data.loopValue,

• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The code shows a clear refactoring where loopValue is being replaced by loopVariableReference. The comment suggests keeping both, but this would go against the apparent design decision to rename the field. The code is consistently using loopVariableReference throughout the file, suggesting this was an intentional change.
  Could there be a reason to maintain backward compatibility by keeping both fields? Could removing loopValue break existing code?
  The code appears to be part of a frontend component where maintaining API compatibility is less critical. The consistent use of loopVariableReference throughout the file suggests this was a deliberate refactoring decision.
  The comment should be deleted as it suggests maintaining redundant fields that would go against the clear refactoring decision made in the code.

Workflow ID: wflow_KEqcKGP500hWWN5I

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.