fix a bug where too many adder nodes are added #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Fixes bug in `getElements` function to prevent adding multiple adder nodes unnecessarily by reusing `adderNodeId`. > > - **Bug Fix**: > - Fixes bug in `getElements` function in `workflowEditorUtils.ts` where multiple adder nodes were added unnecessarily. > - Reuses `adderNodeId` variable instead of redeclaring it, ensuring only one adder node is added per block. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 740d2a606f15ab1e28d4a74dd575dc3294824fb6. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on dfd401f in 15 seconds
More details
- Looked at
22lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_XOXzuu8klsJqxeIR
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to dfd401f in 30 seconds
More details
- Looked at
22lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/workflowEditorUtils.ts:586
- Draft comment:
Reuse theadderNodeIddeclared earlier instead of redeclaring it here to ensure consistency and prevent multiple adder nodes.
// Reuse the adderNodeId declared earlier
- Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_MxrFHUSjEILL2ijM
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Fixes bug in
getElementsfunction inworkflowEditorUtils.tsto prevent adding multiple adder nodes by reusingadderNodeId.getElementsfunction inworkflowEditorUtils.tswhere multiple adder nodes were added unnecessarily.adderNodeIdvariable instead of redeclaring it, ensuring only one adder node is added per block.This description was created by
for dfd401f. It will automatically update as commits are pushed.