Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method BANKSY #131

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Method BANKSY #131

merged 5 commits into from
Dec 14, 2023

Conversation

shdam
Copy link
Contributor

@shdam shdam commented Dec 14, 2023

Implemented Banksy (issue #8)

I don't see a way to not use the method's own way to compute neighbors, so those are used.
It also needs both PCA and expression values, so I use its own method for PCA.

@niklasmueboe niklasmueboe self-requested a review December 14, 2023 10:18
@niklasmueboe niklasmueboe linked an issue Dec 14, 2023 that may be closed by this pull request
method/BANKSY/banksy_env.sh Outdated Show resolved Hide resolved
method/BANKSY/banksy.r Outdated Show resolved Hide resolved
@niklasmueboe
Copy link
Collaborator

@svedziok can you review the conda env generation?

@niklasmueboe niklasmueboe linked an issue Dec 14, 2023 that may be closed by this pull request
@svedziok
Copy link
Contributor

@svedziok can you review the conda env generation?
looks fine; we will then add an additional rule for installing the missing package for this method

@niklasmueboe niklasmueboe merged commit 78c6d23 into main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

method_BANKSY
3 participants