Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native giotto #315

Merged
merged 3 commits into from
Jul 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 31 additions & 23 deletions method/Giotto/Giotto.r
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,16 @@ option_list <- list(
type = "integer", default = NULL,
help = "Number of clusters to return."
),
make_option(
c("--n_pcs"),
type = "integer", default = NULL,
help = "Number of PCs to use."
),
make_option(
c("--n_genes"),
type = "integer", default = NULL,
help = "Number of genes to use."
),
make_option(
c("--technology"),
type = "character", default = NULL,
Expand Down Expand Up @@ -137,7 +147,7 @@ get_SpatialExperiment <- function(

if (!is.na(matrix_file)) {
assay(spe, assay_name, withDimnames = FALSE) <- as(Matrix::t(Matrix::readMM(matrix_file)), "CsparseMatrix")
assay(spe, "logcounts", withDimnames = FALSE) <- log1p(as(Matrix::t(Matrix::readMM(matrix_file)), "CsparseMatrix"))
#spe <- scuttle::logNormCounts(spe)
}

# Filter features and samples
Expand Down Expand Up @@ -165,15 +175,17 @@ spe <- get_SpatialExperiment(
feature_file = feature_file,
observation_file = observation_file,
coord_file = coord_file,
matrix_file = matrix_file,
reducedDim_file = dimred_file
matrix_file = matrix_file
)

## Configuration
method <- "HMRF"
k <- config$k
dims_used <- config$dims_used

n_pcs <- ifelse(is.null(opt$n_pcs), config$n_pcs, opt$n_pcs)
n_genes <- ifelse(is.null(opt$n_genes), config$n_genes, opt$n_genes)
beta <- config$beta
betas <- config$betas
bin_method <- config$bin_method
## Giotto instructions
python_path <- Sys.which(c("python"))
instrs <- createGiottoInstructions(save_dir = out_dir,
Expand All @@ -187,7 +199,7 @@ instrs <- createGiottoInstructions(save_dir = out_dir,
createGiotto_fn = function(spe, annotation = FALSE, selected_clustering = NULL, instructions = NULL){
raw_expr <- SummarizedExperiment::assay(spe, "counts")
#colnames(raw_expr) <- colData(sce)[,"Barcode"]
norm_expression <- SummarizedExperiment::assay(spe, "logcounts")
#norm_expression <- SummarizedExperiment::assay(spe, "logcounts")

cell_metadata <- SingleCellExperiment::colData(spe)
cell_metadata$cell_ID <- rownames(SingleCellExperiment::colData(spe))
Expand All @@ -201,27 +213,22 @@ createGiotto_fn = function(spe, annotation = FALSE, selected_clustering = NULL,
#rownames(norm_expression) <- c(SingleCellExperiment::rowData(sce)[,"SYMBOL"])
}
gobj = Giotto::createGiottoObject(
expression = list("raw" = raw_expr#,
#"normalized" = norm_expression
),
expression = list("raw" = raw_expr),
cell_metadata = cell_metadata,
spatial_locs = as.data.frame(SpatialExperiment::spatialCoords(spe)),
feat_metadata = feat_metadata,
instructions = instructions#,
# Add dimred (doesn't quite work)
#dimension_reduction = GiottoClass::createDimObj(
# coordinates = SingleCellExperiment::reducedDim(spe, "reducedDim"),
# name = "PCA",
# method = "pca")
instructions = instructions
)
return(gobj)
}
# Convert to Giotto object
gobj <- createGiotto_fn(spe, instructions = instrs)

# Normalize
gobj <- Giotto::normalizeGiotto(gobj)
# Alternatively, use the Giotto normalization
gobj <- Giotto::normalizeGiotto(gobj, scalefactor = 6000)

## highly variable features (genes)
gobj <- calculateHVF(gobj)

# PCA
gobj <- runPCA(gobject = gobj, center = TRUE, scale_unit = TRUE, name = "PCA", feats_to_use = NULL)
Expand All @@ -244,19 +251,20 @@ gobj <- Giotto::createSpatialNetwork(
)

# identify genes with a spatial coherent expression profile (Not necessary - default uses all 'selected' features)
km_spatialgenes <- Giotto::binSpect(gobj, bin_method = 'rank')
km_spatialgenes <- Giotto::binSpect(gobj, bin_method = bin_method)
my_spatial_genes <- ifelse(n_genes == 0, km_spatialgenes$feats, km_spatialgenes[1:n_genes]$feats)


#my_spatial_genes <- km_spatialgenes[1:100]$feats
HMRF_spatial_genes <- Giotto::doHMRF(
gobject = gobj,
spat_unit = "cell",
feat_type = "rna",
betas = c(0, 2, config$beta),
betas = betas,
# expression_values = "normalized", # not used when dim_reduction_to_use is given
spatial_genes = km_spatialgenes,
spatial_genes = my_spatial_genes,
dim_reduction_to_use = "pca",
dim_reduction_name = "PCA",
dimensions_to_use = 1:dims_used,
dimensions_to_use = 1:n_pcs,
k = n_clusters,
name = method,
seed = seed
Expand All @@ -272,7 +280,7 @@ HMRF_spatial_genes <- Giotto::doHMRF(
gobj <- addHMRF(
gobject = gobj,
HMRFoutput = HMRF_spatial_genes,
k = k, betas_to_add = c(config$beta),
k = k, betas_to_add = beta,
hmrf_name = method)


Expand Down
1 change: 1 addition & 0 deletions method/Giotto/Giotto.yml
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,7 @@ dependencies:
- r-ini=0.3.1
- r-irdisplay=1.1
- r-irkernel=1.3.2
- r-irlba=2.3.5
- r-isoband=0.2.7
- r-jackstraw=1.3.8
- r-jqr=1.3.3
Expand Down
5 changes: 0 additions & 5 deletions method/Giotto/config/config_1.json

This file was deleted.

9 changes: 9 additions & 0 deletions method/Giotto/config/config_default.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"betas": [0, 2, 10],
"beta": 10,
"k": 10,
"n_pcs": 10,
"n_genes": 0,
"bin_method": "kmeans",
"source": "https://github.com/drieslab/Giotto/blob/a60fbfcaff30a2942f354e63267ae5894aa84cd4/R/python_hmrf.R#L38"
}
9 changes: 9 additions & 0 deletions method/Giotto/config/config_seqfish.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"betas": [28, 2, 3],
"beta": 28,
"k": 9,
"n_pcs": 20,
"n_genes": 100,
"bin_method": "kmeans",
"source": "https://drieslab.github.io/Giotto_website/articles/seqfish_cortex.html#hmrf-spatial-domains"
}
9 changes: 9 additions & 0 deletions method/Giotto/config/config_visium.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"betas": [0, 1, 6],
"beta": 2,
"k": 4,
"n_pcs": 10,
"n_genes": 100,
"bin_method": "rank",
"source": "https://drieslab.github.io/Giotto_website/articles/visium_mouse_kidney.html#spatial-genes"
}