Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript errors in bh-shared-ui #1042

Merged
merged 5 commits into from
Dec 30, 2024
Merged

Fix typescript errors in bh-shared-ui #1042

merged 5 commits into from
Dec 30, 2024

Conversation

elikmiller
Copy link
Contributor

@elikmiller elikmiller commented Dec 26, 2024

Description

This PR accomplishes the following:

  • Fixes a handful of previously uncaught TypeScript errors appearing in packages/javascript/bh-shared-ui
  • Adds js-file-download to the list of exlcuded dependencies when building packages/javascript/bh-shared-ui
  • Ensures TypeScript type checking occurs as part of the build process for both packages/javascript/bh-shared-ui and packages/javascript/js-client-library
  • Adds a new workflow file which attempts to build the BHCE UI application during pull requests or when a new commit is pushed to the main branch

Motivation and Context

This PR addresses: BED-5219

How Has This Been Tested?

Unit tests have been updated. A new workflow file has been added to futher check that a build of the BHCE UI application is possible on all future pull requests or commits to the main branch.

You can inspect the checks for this PR to validate that the changes are working as intended.

Screenshots (optional):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@elikmiller elikmiller self-assigned this Dec 26, 2024
@elikmiller elikmiller added user interface A pull request containing changes affecting the UI code. tooling This updates developer tooling labels Dec 26, 2024
Copy link
Contributor

@sircodemane sircodemane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems pretty straight forward to me

@elikmiller elikmiller merged commit c704775 into main Dec 30, 2024
5 checks passed
@elikmiller elikmiller deleted the BED-5219 branch December 30, 2024 15:47
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tooling This updates developer tooling user interface A pull request containing changes affecting the UI code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants