Feature/strippable #9165
Open
Feature/strippable #9165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced hardcoded prefix and suffix strings with dedicated constants. This improves code readability, maintainability, and reduces the risk of duplication errors. Signed-off-by: Ivandro Jao <[email protected]>
Refactored StrippableText from a class to a struct to improve performance and memory allocation in scenarios where value-type behavior is sufficient. Also included minor formatting adjustments to enhance code readability and maintain consistency. Signed-off-by: Ivandro Jao <[email protected]>
ivandrofly
commented
Jan 2, 2025
| @@ -4,8 +4,11 @@ | |||
|
|
|||
| namespace Nikse.SubtitleEdit.Core.Common | |||
| { | |||
| public class StrippableText | |||
| public struct StrippableText | |||
There was a problem hiding this comment.
This change should bring huge improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.