Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh git proxy tokens when patching amalthea sessions #592

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

olevski
Copy link
Member

@olevski olevski commented Dec 25, 2024

/deploy

Also makes sure that starting a session and patching rely on the same
function when it comes to templating the same parts of an
AmaltheaSession spec.
@olevski olevski requested a review from a team as a code owner December 25, 2024 15:51
@olevski olevski marked this pull request as draft December 25, 2024 15:51
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-592.dev.renku.ch

@coveralls
Copy link

coveralls commented Dec 25, 2024

Pull Request Test Coverage Report for Build 12497808039

Details

  • 82 of 291 (28.18%) changed or added relevant lines in 7 files are covered.
  • 14 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.5%) to 86.357%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/notebooks/crs.py 18 19 94.74%
components/renku_data_services/notebooks/config/dynamic.py 6 8 75.0%
components/renku_data_services/notebooks/api/classes/k8s_client.py 2 11 18.18%
components/renku_data_services/notebooks/utils.py 2 11 18.18%
components/renku_data_services/notebooks/models.py 12 30 40.0%
components/renku_data_services/notebooks/blueprints.py 5 32 15.63%
components/renku_data_services/notebooks/core_sessions.py 37 180 20.56%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_api/error_handler.py 1 89.47%
components/renku_data_services/base_api/misc.py 1 98.36%
components/renku_data_services/notebooks/blueprints.py 1 58.59%
components/renku_data_services/storage/blueprints.py 2 95.69%
components/renku_data_services/storage/models.py 2 84.11%
components/renku_data_services/notebooks/api/classes/k8s_client.py 7 61.98%
Totals Coverage Status
Change from base Build 12464122126: -0.5%
Covered Lines: 15305
Relevant Lines: 17723

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants