-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(cypress): add a new tests to verify secrets are mounted properly #3612
base: master
Are you sure you want to change the base?
Conversation
You can access the deployment of this PR at https://ci-renku-3612.dev.renku.ch |
df36d29
to
db3d3c2
Compare
577b3ed
to
cb5ef62
Compare
I'm not sure a feature dubbed as "alpha" should have an acceptance test 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is an appropriate PR to leave Changeling comments, since I didn't get to comment on the initial PR ?
cb5ef62
to
4c61f51
Compare
Sorry @lokijuhy the Do you mind moving the release/feature change requests to the release PR? |
Why not? The feature is labeled as "alpha" because we want to be reasonably sure everything is working as expected before users rely on it. With this acceptance test, we check that other changes to the system don't accidentally break the feature. It seems reasonable to add one now since there are newly introduced components that are not covered by any other test. |
7f48fc5
to
aee6bd6
Compare
61f2b75
to
414763e
Compare
@lorenzo-cavazzi the test seems to have failed in the last run |
That test seems to be somewhat flaky recently |
It's the new test from this PR! So it should be checked if this is because there is an issue with user secrets in this PR's deployment or if the test is not robust. |
Yes, we should not merge this "as is". Somehow, the test fails much more frequently than it should. From the videos, it seems that starting the session takes forever, but when doing it manually it's almost always quicker.
|
@lorenzo-cavazzi please target release-0.53.x |
The base branch was changed.
94f1e32
to
10d7cf6
Compare
This PR adds a new acceptance test for the new User Secrets feature
/deploy