Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: make unwanted method internal #121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PascalSenn
Copy link
Member

The extension method ObjectWrapperRemover.RemoveUnwantedWrappers is public
This extension method extends object and therefor is displayed by intellisense on every object

Breaking Change

This change is technically breaking. So in terms of semver this should probably wait for the next major release

@PascalSenn PascalSenn added the enhancement New feature or request label Feb 2, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@swisslife-bot
Copy link
Contributor

swisslife-bot commented Feb 2, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@nscheibe nscheibe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@glucaci
Copy link
Member

glucaci commented Feb 27, 2021

Nice please sign the CLA than we are good to go ;)

@PascalSenn
Copy link
Member Author

done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants