Implemented rule to avoid duplicates

[mbauerdev]

The current Thor implementation silently swallows all events that are passed into an event-method that has a non-unique event identifier. The changes in this PR should detect this issue within an event source:

    [EventSource(Name = "NonUniqueEventId")]
    public class NonUniqueEventIdEventSource
        : EventSource
    {
        [Event(1)] // <-- Duplicate here...
        public void Foo1a(string bar)
        {
            WriteEvent(1, bar);
        }

        [Event(1)] // <-- Duplicate here...
        public void Foo1b(string bar)
        {
            WriteEvent(1, bar);
        }
}

[swisslife-bot]

All committers have signed the CLA.

[joslat]

I believe I am wrong and those tests are not used as tests but as rules, so then all is good. Except some spacing, or lines before the return ;) - but that's not serious as here there is no SonarQbe...

[joslat]

I like to have one of the naming conventions (or similar) on the test mehtods. even better when the project's test methods naming are consisten, like "MethodName_StateUnderTest_ExpectedBehavior" which is the one I usually use... with method name I putthe action performed like "ApplyingNonUniqueEventId_ToAnEventSource_ShouldRaiseAnError" for example.

[mbauerdev]

Very good point - I usually follow that rule. But in this case, I decided to have consistency over "correctness"... All other tests follow the same naming pattern.

[joslat]

I like a return(line) before the return, used to that as this is on other methods too. but haven't seen the rest of code, depends if this is consistent with the rest of the code...

[joslat]

I'd remove this

[joslat]

or add the above line before this return ;)