Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for jieba library #25

Closed
wants to merge 2 commits into from
Closed

Add unit tests for jieba library #25

wants to merge 2 commits into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Jan 3, 2024

PR Feedback: 👎

I created this PR to address this rule:

"All new business logic should have corresponding unit tests."

Description

This PR addresses the issue of missing unit tests for the jieba library. The tests/test_jieba.py file, which was supposed to contain these tests, was missing. This PR adds the tests/test_jieba.py file and includes the necessary unit tests for the jieba library.

The tests cover all the functionalities provided by the jieba library that are used within the Whoosh project. They have been written using the pytest framework and can be executed using the command specified in the tox.ini file.

In addition, the MANIFEST.in file has been updated to include the tests/test_jieba.py file in the distribution package.

Summary of Changes

  • Created tests/test_jieba.py and added unit tests for the jieba library.
  • Updated MANIFEST.in to include tests/test_jieba.py in the distribution package.

All tests pass successfully.

Copy link
Contributor Author

sweep-ai bot commented Jan 3, 2024

Rollback Files For Sweep

  • Rollback changes to tests/test_jieba.py
  • Rollback changes to tests/test_jieba.py
  • Rollback changes to MANIFEST.in
  • Rollback changes to MANIFEST.in
  • Rollback changes to MANIFEST.in

@sweep-ai sweep-ai bot added the sweep label Jan 3, 2024
Copy link
Contributor Author

sweep-ai bot commented Jan 3, 2024

Sandbox Executions

  • Running GitHub Actions for tests/test_jieba.py
Check tests/test_jieba.py with contents:

Ran GitHub Actions for b9af8f6c2f3b5241bbfcaa73e860f29029d5108c:

  • Running GitHub Actions for MANIFEST.in
Check MANIFEST.in with contents:

Ran GitHub Actions for b9af8f6c2f3b5241bbfcaa73e860f29029d5108c:
• tox (ubuntu-latest, pypy3.10):
• test (3.12):
• tox (ubuntu-latest, 3.12):
• test (3.11):
• tox (ubuntu-latest, 3.11):
• test (3.10):
• tox (ubuntu-latest, 3.10):
• tox (ubuntu-latest, 3.9):
• test (3.9):
• test (3.8):
• tox (ubuntu-latest, 3.8):

@ZeroCool940711 ZeroCool940711 marked this pull request as draft January 3, 2024 19:09
@ZeroCool940711 ZeroCool940711 removed their assignment Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant