Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting, more tests and Python 3.8+ conversions. #54

Closed
wants to merge 0 commits into from

Conversation

ZeroCool940711
Copy link
Contributor

@ZeroCool940711 ZeroCool940711 commented Feb 7, 2024

This PR includes formatting/spacing fixes, I added more tests for some basic functions and converted many different things to Python 3.8+.
This PR will take some time to be ready to merge and it will most likely have breaking changes since we are renaming many functions, arguments and variables from using mixedCase to snake_case. There are as well many changes to the documentation because of the previously mentioned renaming. I also tried to fix as many bugs, vulnerabilities, issues and code smells reported by SonarCloud.io as I could and I plan to continue doing so until the numbers are as close to 0 as possible, should take a week or two based on the current progress.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (53bf520) 98.56% compared to head (98c37d3) 98.55%.

Files Patch % Lines
tests/test_classify.py 98.91% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   98.56%   98.55%   -0.01%     
==========================================
  Files          34       34              
  Lines        9864     9930      +66     
  Branches     1318     1318              
==========================================
+ Hits         9722     9787      +65     
- Misses        122      123       +1     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZeroCool940711
Copy link
Contributor Author

ZeroCool940711 commented Feb 7, 2024

mmm, it seems like both, the Codecov and SonarCloud.io bots have configuration issues, I have to look into that. Codecov doesnt seem to be looking at the right files, it's looking at what is inside the tests folder instead of what is on the src folder. The Sonarcloud.io bot on the other side is not showing the same information here as what is shown on the website or even on the GitHub action, which is actually failing for that, since there are a lot of problems I still have to fix. Most of the changes I am doing are based on what SonarCloud.io shows on their website and what I get with their SonarLint VSCode extension, which is really helpful for some stuff that I would have a hard time figuring out on my own or would have to spend a lot of time on it.

@ZeroCool940711 ZeroCool940711 added the migration Migrate from one version to another of a specific software. label Feb 7, 2024
@cclauss
Copy link
Collaborator

cclauss commented Feb 7, 2024

Just do a single PR that is ruff format .

Then on later PRs do other stuff. Ruff does everything that black, flynt, isort, and pyupgrade does but is much faster.

ZeroCool940711 added a commit that referenced this pull request Feb 7, 2024
# Description

`ruff format . && ruff --select=I --fix .`

Replaces both `black` and `isort` with `ruff` running rapidly in
`pre-commit`.

This separates automatic formatting changes (this PR) from more manual
and syntactical changes (in #54) to make the latter easier to review and
revert if necessary.

# Checklist:

- [x] I have performed a self-review of my code
- [ ] I have added comments to code where it is hard to understand
- [ ] I have made corresponding changes to the documentation
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration Migrate from one version to another of a specific software.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants