-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting, more tests and Python 3.8+ conversions. #54
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 98.56% 98.55% -0.01%
==========================================
Files 34 34
Lines 9864 9930 +66
Branches 1318 1318
==========================================
+ Hits 9722 9787 +65
- Misses 122 123 +1
Partials 20 20 ☔ View full report in Codecov by Sentry. |
mmm, it seems like both, the Codecov and SonarCloud.io bots have configuration issues, I have to look into that. Codecov doesnt seem to be looking at the right files, it's looking at what is inside the |
Just do a single PR that is Then on later PRs do other stuff. Ruff does everything that black, flynt, isort, and pyupgrade does but is much faster. |
# Description `ruff format . && ruff --select=I --fix .` Replaces both `black` and `isort` with `ruff` running rapidly in `pre-commit`. This separates automatic formatting changes (this PR) from more manual and syntactical changes (in #54) to make the latter easier to review and revert if necessary. # Checklist: - [x] I have performed a self-review of my code - [ ] I have added comments to code where it is hard to understand - [ ] I have made corresponding changes to the documentation
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
This PR includes formatting/spacing fixes, I added more tests for some basic functions and converted many different things to Python 3.8+.
This PR will take some time to be ready to merge and it will most likely have breaking changes since we are renaming many functions, arguments and variables from using
mixedCase
tosnake_case
. There are as well many changes to the documentation because of the previously mentioned renaming. I also tried to fix as many bugs, vulnerabilities, issues and code smells reported by SonarCloud.io as I could and I plan to continue doing so until the numbers are as close to 0 as possible, should take a week or two based on the current progress.