Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the tests that were failing due to circular imports introduced in PR #55 #56

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

ZeroCool940711
Copy link
Contributor

Fixes: This PR fixes the tests errors introduced in PR #55

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (53bf520) 98.56% compared to head (c3e62bc) 98.55%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   98.56%   98.55%   -0.01%     
==========================================
  Files          34       34              
  Lines        9864     9839      -25     
  Branches     1318     1318              
==========================================
- Hits         9722     9697      -25     
  Misses        122      122              
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZeroCool940711 ZeroCool940711 merged commit 9a2e2ac into Sygil-Dev:main Feb 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant