Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable and update URLs #61

Merged
merged 7 commits into from
Feb 9, 2024

Conversation

ZeroCool940711
Copy link
Contributor

This pull request includes the following changes:

  • Remove the unused local variable "end".

  • Used https in some URLs instead of http for security.

  • Added Codiumai.toml file to configure the VS Code extension. This can be used for generating a large number of tests covering different scenarios as well as general code improvements.

  • Removed old xrange/range import from whoosh.compact that was there to fix issues on old Python versions (2.7-3.6). We have removed this since we are trying to focus on support for Python 3.8+ and this code would just be duplicated code that is hard to maintain.

  • Added a few more tests to increase coverage.

  • Added .codiumai.local.toml to the gitignore since this file is meant to be ignored and not on the repo.

… be used for generating a large number of tests covering different scenarios as well as general code improvements.
… fix issues on old Pyton versions (2.7-3.6). We have removed this since we are trying to focus on support for Python 3.8+ and this code would just be duplicated code that is hard to maintain.
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (b85d900) 80.92% compared to head (53db475) 80.97%.

Files Patch % Lines
tests/test_columns.py 92.38% 0 Missing and 8 partials ⚠️
src/whoosh/automata/fsa.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   80.92%   80.97%   +0.05%     
==========================================
  Files         133      133              
  Lines       29410    29496      +86     
  Branches     5053     5066      +13     
==========================================
+ Hits        23799    23884      +85     
+ Misses       4742     4737       -5     
- Partials      869      875       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZeroCool940711 ZeroCool940711 merged commit 4074baf into Sygil-Dev:main Feb 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant