forked from verilog-to-routing/vtr-verilog-to-routing
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from verilog-to-routing:master #565
Open
pull
wants to merge
8,937
commits into
SymbiFlow:master
Choose a base branch
from
verilog-to-routing:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
VPR
libarchfpga
lang-python
scripts
libvtrutil
tests
liblog
labels
Sep 7, 2021
Added comments based on Vaughn's suggestions.
[NDMatrix] Resolved Dangling Reference Warning
Net decomposing router: hotfix
Resolved a warning in search_bar.cpp which warned about a reference to a temporary. Simply fixed by splitting the statement into two lines. Resolved a warning in draw_rr.cpp where a print statement was trying to access an invalid location in an array. The print statement did not make sense, it was trying to print an undefined side. This was removed. Resolved a warning in the automatically generated vpr_constraints and rr_graph files. This was an interesting warning due to the decltype method returning the attributes of the FILE pointer, but this was passed into a template which discards the attributes (this generates a warning). Resolved this manually locally and raised a PR on the uxsdcxx repo with this fix: SymbiFlow/uxsdcxx#53
[Warnings] Resolved Basic Warnings for GCC13
Fixed a warning with a loop induction variable not being initialized. Fixed a warning where a method overrides the base class, but was not explicitly declared as override.
[Warnings] Fixed Minor Warnings
…okahead Simple Place Delay Model Read/Write
Update docs for parallel router
IPIN Cost Multiplier
fix a warning [-Werror=stringop-truncation] occurs in sockcpp module on ubuntu 24.04 CI
Now that the GCC-13 build on Ubuntu Noble is warning clean, adding it to the CI to maintain it. This is a stepping stone to moving the entire CI to Ubuntu Noble.
The G_APPLICATION_FLAGS_NONE enum was deprecated in recent versions of GLib and was replaced by G_APPLICATION_DEFAULT_FLAGS; however, the replacement enum was not introduced until GLib 2.74. Added code that will select which enum to use depending on the GLib version to keep EZGL backwards compatible.
[CI] Added GCC-13 on Ubuntu Noble as a Compatibility Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )