Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing comma in DATABASES dictionary #9

Merged

Conversation

cgmcintyr
Copy link

Fixes following error when running bin/yscb script:

File "./bin/ycsb", line 86
    "hbase098"     : "com.yahoo.ycsb.db.HBaseClient",
                   ^
SyntaxError: invalid syntax

@Vogel612
Copy link

Vogel612 commented Mar 3, 2018

That's a nice catch, thanks. But why not just drop a comment on the still-open PullRequest?

The branch you're PRing to is not intended for use in it's current state. It is very much under active development...

@Vogel612
Copy link

Vogel612 commented Mar 3, 2018

As a sidenote: I will be able to merge this PR only after fixing a current problem with kdbplus-java

@cgmcintyr
Copy link
Author

cgmcintyr commented Mar 3, 2018

RE: #9 (comment)

Do you mean this PR brianfrankcooper#1095? The missing comma was introduced with af83dbd, so doesn't affect that PR or other branches.

This is a bit of a silly PR, and I was thinking of raising an issue, but thought it would be easier to submit a 1 line patch that could be pulled in 🤷

I checked out this branch as I'm trying to a 50/50 read/insert workload using YCSB-TS on kairosdb but have been getting errors. I was hoping there might have been a fix with all the work you've been doing on this branch :)

@Vogel612
Copy link

Vogel612 commented Mar 3, 2018

Do you mean this PR brianfrankcooper#1095?

I meant brianfrankcooper#1068.

I checked out this branch as I'm trying to a 50/50 read/insert workload using YCSB-TS on kairosdb but have been getting errors.

Please do submit an issue for the kairosdb problem you're seeing. I've only been moving stuff over for now. Validating that everything runs as expected is the next step.

@Vogel612 Vogel612 merged commit 8554ba7 into TSDBBench:fork-folding Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants