Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add VERSION_NUMERIC constant #635

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

un-pogaz
Copy link

@un-pogaz un-pogaz commented Dec 11, 2024

Adding a numeric tuple version to easily test the current version of TagStudio running. Close #634.

@CyanVoxel CyanVoxel added the Type: Refactor Code that needs to be restructured or cleaned up label Dec 12, 2024
@CyanVoxel
Copy link
Member

While this is a useful change for testing the version number, I don't feel that it's immediately necessary and is just making a change based off of future assumptions (as #634 mentions, "[Forward features for plugins]").

The version number is something I've liked to store somewhere else for quite some time now, so that it's available to other parts of the program + project, most notably the build workflows. This will probably involve keeping it inside the pyproject.toml instead of this constants file. If I were to pull this, it would mean either breaking that future use case or just creating more refactor work for us in the future with little to no benefit in the meantime, as nothing currently uses this tuple check.

If the version number was kept in the pyproject.toml and then loaded into the project as a string and/or tuple (old JSON code checks the string iirc) then I think that would have the best of both worlds here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactor Code that needs to be restructured or cleaned up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Easy test of current version of TagStudio
2 participants