Fix: [Bug] Accent colors show as Gray on windows #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Bug
|
Unfortunately this doesn't resolve it on my machine, in fact skipping the HSL steps entirely still doesn't get me the original accent color and is still always some middle shade of gray... |
|
Weird, i just tried with the same colour used in the issue and got the same result. this issue only seems to be effecting really light colours since darker colours work just fine, ill try do some more looking around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not too sure why the behaviour changed between versions of PySide but this seems to fix it on the newest version.
the colour limit was set too high so if you had a bright accent colour it would become closer to white/gray due to being too bright.
i cant speak for how this change looks on other platforms though so it should be tested there but on windows at least it brings back the colour and still creates an obvious select effect
close #668