-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add table of contents for docs pages #308
Conversation
Someone is attempting to deploy a commit to the Tanstack Team on Vercel. A member of the Team first needs to authorize it. |
❌ Deploy Preview for tanstack failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nos43ratu please resolve the conflicts
fbe92c6
to
ad7a330
Compare
@SeanCassiere updated pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! @tannerlinsley any thoughts here?
I'm a bit concerned that there appears to be 3 scrollbars on that 2nd image, when 2 should be the max. But otherwise, I think this would be a welcome addition. |
@KevinVandy it can be fixed by making content margins smaller and moving toc out from right side |
or making scroll inside of the toc invisible |
When a wide enough media query is triggered, that might be good. Otherwise probably needs to stay in one side bar on medium sized screens, and hidden on mobile |
The draft looks better. Maybe just add a light border on the left and hide it on small screens. |
ad7a330
to
477fff1
Compare
Moved toc from right side bar to the page. Saved initial page width. Made pr thiner by removing unnecessary changes. This version can be reverted to use initial version @SeanCassiere @KevinVandy @tannerlinsley Screen.Recording.2024-11-28.at.05.09.59.mp4 |
On http://localhost:3000/router/latest/docs/framework/react/api/router there seems to be some content width issues. |
477fff1
to
41ec4d8
Compare
@SeanCassiere fixed |
@tannerlinsley This passes my qa from just looking at the table docs. I think it makes the docs a lot easier to navigate Approving, but not merging until @tannerlinsley approves/merges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are great! I checked them out with the docs for Router, Query, and Form.
Fantastic! Approved! |
@Nos43ratu thank you for your contribution 🎉 |
Thanks guys 🙏 |
Problem: The current documentation pages, like Router Navigation, can be challenging to navigate due to their length and density of content.
Solution: Added a Table of Contents (ToC) to the right sidebar to enhance navigation.
Changes Made: