-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fresh data w/ Convex for open source stats #309
Conversation
@erquhart is attempting to deploy a commit to the Tanstack Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for tanstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty cool!
7565428
to
32a6716
Compare
0ad33f3
to
531074b
Compare
aa7f8d0
to
aa70f3c
Compare
Looks good to me! Looking forward to seeing this on the site |
aa70f3c
to
4eab367
Compare
@thomasballinger the current version doesn't do this, I think partly because the size of the numbers impacts the width, which changes responsively. Can definitely do if desired! Just pointing out that it's pre-existing. |
ah gotcha! |
We're using netlify now. Does that change anything? |
Screen.Recording.2024-11-26.at.11.55.18.AM.mov
This PR makes the OSS stats data as live as it can get:
Everything is updated to latest available hourly.
Primary changes
Ancillary changes
satisfies
to explicit types to address errors in the libraries index component.Required steps
pnpm dev:convex
locally and create a new Convex project (you'll be prompted)GITHUB_ACCESS_TOKEN
<http-actions-url>/events/github
application/json
GITHUB_WEBHOOK_SECRET
GITHUB_ACCESS_TOKEN
andGITHUB_WEBHOOK_SECRET
env vars should be added to both development and production Convex deployments in the dashboardnpx convex run stats:sync
npx convex run stats:sync --prod
app/router.tsx
- replace this with the url to the production instance that was just created. Hardcoding this allows local development to work without requiring a convex dev instance for the developer. They'll only need one if they're developing in the convex directory.