Closes #620: remove Thread.sleep from integration tests #628
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace all Thread.sleep calls with better Awaitility.await
SonarCloud Results
Unfortunately I needed to create a class ordering for JUnit to execute at leaset the class
pro.taskana.adapter.integration.TestDisabledTaskClaim
at first. I din't figure out why this needs to be the case.To check the tests for flakyness a created a test script
mvnw_clean_install_20_times.sh
I executed a complete./mvnw clean install
run 20 times and no errors occured. For details please check attachmentclean_install_results.txt.tar.gz for more details.
For the reviewers: please review the assert in the awaitibilty when a waiting is successful.
old execution time
new exection time
Release Notes:
For the submitter:
Verified by the reviewer: