Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #620: remove Thread.sleep from integration tests #628

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arolfes
Copy link
Contributor

@arolfes arolfes commented Nov 28, 2023

replace all Thread.sleep calls with better Awaitility.await

SonarCloud Results

Unfortunately I needed to create a class ordering for JUnit to execute at leaset the class pro.taskana.adapter.integration.TestDisabledTaskClaim at first. I din't figure out why this needs to be the case.

To check the tests for flakyness a created a test script mvnw_clean_install_20_times.sh I executed a complete ./mvnw clean install run 20 times and no errors occured. For details please check attachment
clean_install_results.txt.tar.gz for more details.

For the reviewers: please review the assert in the awaitibilty when a waiting is successful.

old execution time
image

new exection time
image


Release Notes:

# Improvements:
* all integrationtests using Awaitility.wait which decreases the execution time over 2 minutes 

For the submitter:

Verified by the reviewer:

  • Commit message format → ADPT-XXX: Your commit message.
  • Submitter's update to documentation is sufficient
  • SonarCloud analysis meets our standards
  • Update of the current release notes reflects changes
  • PR fulfills the ticket
  • Edge cases and unwanted side effects are tested
  • Readability

replace all Thread.sleep calls with better Awaitility.await
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactore integration tests that they don't use Thread.sleep anymore
1 participant