perf(select): group title not exist still renders children

Tencent · Jan 3, 2025 · e3b2909 · e3b2909
1 parent d0c71e5
commit e3b2909
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/src/select/hooks/useSelectOptions.ts b/src/select/hooks/useSelectOptions.ts
@@ -33,7 +33,7 @@ export const useSelectOptions = (props: TdSelectProps, keys: Ref<KeysType>, inpu
           dynamicIndex++;
           return res;
         };
-        if ((option as SelectOptionGroup).group && (option as SelectOptionGroup).children) {
+        if ((option as SelectOptionGroup).children) {
           return {
             ...option,
             children: (option as SelectOptionGroup).children.map((child) => getFormatOption(child)),
@@ -84,7 +84,7 @@ export const useSelectOptions = (props: TdSelectProps, keys: Ref<KeysType>, inpu
     const res: TdOptionProps[] = [];
     const getOptionsList = (options: TdOptionProps[]) => {
       for (const option of options) {
-        if ((option as SelectOptionGroup).group) {
+        if ((option as SelectOptionGroup).children) {
           getOptionsList((option as SelectOptionGroup).children);
         } else {
           res.push(option);
@@ -120,7 +120,7 @@ export const useSelectOptions = (props: TdSelectProps, keys: Ref<KeysType>, inpu
     const res: SelectOption[] = [];
 
     options.value.forEach((option) => {
-      if ((option as SelectOptionGroup).group && (option as SelectOptionGroup).children) {
+      if ((option as SelectOptionGroup).children) {
         res.push({
           ...option,
           children: (option as SelectOptionGroup).children.filter(filterMethods),

diff --git a/src/select/option-group-props.ts b/src/select/option-group-props.ts
@@ -13,6 +13,5 @@ export default {
   /** 分组别名 */
   label: {
     type: String,
-    default: '',
   },
 };
diff --git a/src/select/optionGroup.tsx b/src/select/optionGroup.tsx
@@ -23,7 +23,7 @@ export default defineComponent({
 
     return () => (
       <li class={classes.value}>
-        <div class={`${COMPONENT_NAME.value}__header`}>{props.label}</div>
+        {(props.label ?? false) && <div class={`${COMPONENT_NAME.value}__header`}>{props.label}</div>}
         {renderTNodeJSX('default')}
       </li>
     );

diff --git a/src/select/select-panel.tsx b/src/select/select-panel.tsx
@@ -64,7 +64,7 @@ export default defineComponent({
       return (
         <ul class={`${COMPONENT_NAME.value}__list`}>
           {options.map((item: SelectOptionGroup & TdOptionProps & { slots: Slots } & { $index: number }, index) => {
-            if (item.group) {
+            if (item.children) {
               return (
                 <OptionGroup label={item.group} divider={item.divider}>
                   {renderOptionsContent(item.children)}