Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr accepted in other repo that fixes these flaky tests #1500

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

mumbler6
Copy link
Contributor

I made a PR with a fix in the original repo here: adobe/aem-core-wcm-components#2894

The developer wanted a different fix which involves a PR to a separate dependent project: wcm-io/io.wcm.testing.aem-mock#52

@mumbler6
Copy link
Contributor Author

I think the format checker failed my PR since the fix is in a different GitHub repository. What should I do?

@darko-marinov
Copy link
Contributor

Was there an ID test in the other repo that you could add to IDoFT? If yes, please add it. If not, please put the PR Link in the Notes here and add InspiredAFix -- I know it's not an ideal characterization, but we don't have anything like AcceptedInAnotherRepo.

@mumbler6
Copy link
Contributor Author

Can I replace the PR link with the adobe one and move the accepted PR in wcm.io to Notes?

https://github.com/adobe/aem-core-wcm-components,5f29cc86b17b6db36cc617805295eb951b6504a1,bundles/core,com.adobe.cq.wcm.core.components.internal.models.v1.PageImplTest.testPage,ID,Accepted,https://github.com/adobe/aem-core-wcm-components/pull/2894,https://github.com/wcm-io/io.wcm.testing.aem-mock/pull/52

@darko-marinov
Copy link
Contributor

Yes, that's fine. Please change it so that the format checker passes.

@darko-marinov darko-marinov merged commit d25480c into TestingResearchIllinois:main Nov 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants