Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autotuner] CI Smoke Test - Tune & Sweep #2042

Merged
merged 33 commits into from
Sep 11, 2024
Merged

[Autotuner] CI Smoke Test - Tune & Sweep #2042

merged 33 commits into from
Sep 11, 2024

Conversation

luarss
Copy link
Contributor

@luarss luarss commented Jun 2, 2024 •
edited
Loading

@vvbandeira
Goal is to do smoke test using CLI function call.
Supports all platforms: asap7, sky130hd, ihp-sg13g2, gf180

  • Tune
  • Sweep
  • Change Jenkinsfile and test_helper.sh

rovinski
rovinski reviewed Jun 4, 2024
View reviewed changes
tools/AutoTuner/src/autotuner/__init__.py Outdated Show resolved Hide resolved
tools/AutoTuner/README.md Outdated Show resolved Hide resolved
@luarss luarss self-assigned this Jun 4, 2024
@luarss luarss added autotuner Flow autotuner and removed In Progress labels Jun 4, 2024
@luarss luarss marked this pull request as ready for review June 5, 2024 17:59
@luarss luarss requested a review from vvbandeira June 5, 2024 17:59
@luarss luarss changed the title [Autotuner] Autotuner CI Smoke Test [Autotuner] CI Smoke Test - Tune & Sweep Jun 8, 2024
vvbandeira
vvbandeira requested changes Jun 11, 2024
View reviewed changes
tools/AutoTuner/src/autotuner/distributed.py Outdated Show resolved Hide resolved
tools/AutoTuner/test/smoke_test_sweep.py Outdated Show resolved Hide resolved
tools/AutoTuner/test/smoke_test_tune.py Outdated Show resolved Hide resolved
docs/user/InstructionsForAutoTuner.md Outdated Show resolved Hide resolved
@luarss luarss requested a review from vvbandeira June 13, 2024 01:32
vvbandeira
vvbandeira reviewed Jul 9, 2024
View reviewed changes
tools/AutoTuner/src/autotuner/distributed.py Outdated Show resolved Hide resolved
docs/user/InstructionsForAutoTuner.md Outdated Show resolved Hide resolved
docs/user/InstructionsForAutoTuner.md Outdated Show resolved Hide resolved
@luarss luarss requested a review from vvbandeira July 13, 2024 03:10
@vvbandeira vvbandeira enabled auto-merge (squash) July 23, 2024 18:20
auto-merge was automatically disabled July 24, 2024 17:26

Head branch was pushed to by a user without write access

@luarss luarss force-pushed the autotuner_ci_level_1 branch from 587f00d to a689096 Compare July 24, 2024 17:26
@luarss luarss requested a review from vvbandeira July 24, 2024 17:30
@vvbandeira
Copy link
Member

@luarss
CI is failing to find AT files:

Install dependencies in Venv
+ ./tools/AutoTuner/installer.sh
flow/test/test_helper.sh: line 85: ./tools/AutoTuner/installer.sh: No such file or directory

@luarss
Copy link
Contributor Author

luarss commented Jul 27, 2024

@luarss CI is failing to find AT files:

Install dependencies in Venv
+ ./tools/AutoTuner/installer.sh
flow/test/test_helper.sh: line 85: ./tools/AutoTuner/installer.sh: No such file or directory

This is because the installer script is in the other PR #2025

@vvbandeira
Copy link
Member

@luarss
Please fix merge conflict.

@luarss luarss force-pushed the autotuner_ci_level_1 branch from f074911 to 13f3fdb Compare August 9, 2024 06:39
@luarss
Copy link
Contributor Author

luarss commented Aug 9, 2024

@vvbandeira I see that ./tools/AutoTuner files are not being copied into the docker image, see the latest run: https://jenkins.openroad.tools/job/OpenROAD-flow-scripts-Public/job/PR-2042-merge/74/pipeline-console/?selected-node=164

Any ideas?

@luarss luarss force-pushed the autotuner_ci_level_1 branch from 8ec7068 to c35a205 Compare September 1, 2024 13:29
vvbandeira
vvbandeira requested changes Sep 1, 2024
View reviewed changes
tools/AutoTuner/.gitignore Show resolved Hide resolved
tools/AutoTuner/test/smoke_test_sweep.py Show resolved Hide resolved
tools/AutoTuner/test/smoke_test_tune.py Show resolved Hide resolved
tools/AutoTuner/.gitignore Outdated Show resolved Hide resolved
@luarss luarss requested a review from vvbandeira September 1, 2024 15:33
luarss and others added 23 commits September 7, 2024 10:24
@luarss
address comments
929f4c0 
Signed-off-by: Jack Luar <[email protected]>
@luarss
fix gcd unstable and genreport
1515977 
Signed-off-by: luarss <[email protected]>
@luarss
hotfix for autotuner report files
c7caaf3 
Signed-off-by: luarss <[email protected]>
@luarss
add ihp gcd params
f3f7834 
Signed-off-by: Jack Luar <[email protected]>
@luarss
fix comments
04b156f 
Signed-off-by: luarss <[email protected]>
@luarss
fix doc clarity comments
fc25ef9 
Signed-off-by: luarss <[email protected]>
@vvbandeira @luarss
Update flow/test/test_helper.sh
e869d70 
Signed-off-by: Vitor Bandeira <[email protected]>
@vvbandeira @luarss
Update flow/test/test_helper.sh
ea7bd88 
Signed-off-by: Vitor Bandeira <[email protected]>
@vvbandeira @luarss
Update tools/AutoTuner/setup.sh
1e4204c 
Signed-off-by: Vitor Bandeira <[email protected]>
@luarss
fix black
4cab7e1 
Signed-off-by: luarss <[email protected]>
@luarss
no need cd ../
fa5bf3c 
Signed-off-by: luarss <[email protected]>
@luarss
Fix chmod x issues
3f2c53d 
Signed-off-by: Jack Luar <[email protected]>
@luarss
add debug print
1ee2829 
Signed-off-by: Jack Luar <[email protected]>
@luarss
test copy tools/AutoTuner
003f0d0 
Signed-off-by: Jack Luar <[email protected]>
@luarss
slimmer gitignore and add test_xx functions for the base class
73f600c 
Signed-off-by: luarss <[email protected]>
@vvbandeira @luarss
Update docker/Dockerfile.builder
5458ba5 
Signed-off-by: Vitor Bandeira <[email protected]>
@luarss
fix py syntax and dockerfile
97b1ec2 
Signed-off-by: luarss <[email protected]>
@luarss
ci: bump version
b885f3e 
The new version makes sure to copy the required info into the container
so that AT CI can run correctly.

Signed-off-by: Vitor Bandeira <[email protected]>
@luarss
revert Dockerfile and fix installer
e854383 
Signed-off-by: luarss <[email protected]>
@luarss
revert Dockerfile and change installer to use py3
ad2f451 
Signed-off-by: luarss <[email protected]>
@luarss
No more cd during installer, standardise setup script and add gitignore
7250930 
Signed-off-by: luarss <[email protected]>
@luarss
source setup script
9eadabb 
Signed-off-by: luarss <[email protected]>
@luarss
add PATH to export
8335a2e 
Signed-off-by: luarss <[email protected]>
@luarss luarss force-pushed the autotuner_ci_level_1 branch from 7c183cf to 8335a2e Compare September 7, 2024 10:25
vvbandeira
vvbandeira requested changes Sep 11, 2024
View reviewed changes
tools/AutoTuner/installer.sh Outdated Show resolved Hide resolved
flow/test/test_helper.sh Outdated Show resolved Hide resolved
@vvbandeira vvbandeira enabled auto-merge (squash) September 11, 2024 13:09
@vvbandeira vvbandeira merged commit ec45357 into The-OpenROAD-Project:master Sep 11, 2024
6 checks passed
@luarss luarss deleted the autotuner_ci_level_1 branch September 13, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rovinski rovinski rovinski left review comments

@vvbandeira vvbandeira vvbandeira approved these changes

Assignees

@luarss luarss

Labels
autotuner Flow autotuner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luarss @vvbandeira @rovinski