Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: clang-format application can be overzealous #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yrashk
Copy link

@yrashk yrashk commented Oct 15, 2024

Solution: allow excluding certain paths
by specifying them in the CLANG_FORMAT_IGNORED_PATHS list


This is just a quick solution to a problem I had with a lot of vendored dependencies in the repo where I needed this. Happy to discuss if there's a better solution!

Solution: allow excluding certain paths
by specifying them in the CLANG_FORMAT_IGNORED_PATHS list
@ClausKlein
Copy link
Contributor

What is your use case? It should do the same like git clang-format

@TheLartians
Copy link
Owner

TheLartians commented Oct 16, 2024

@yrashk could it be a better solution to add a .clang-format-ignore file that includes the vendored dependency directory?
For example as described in this post.

@ClausKlein
Copy link
Contributor

But than you need to update your copy of clang-format.py to llvm v18 or newer!

@yrashk
Copy link
Author

yrashk commented Oct 16, 2024

And that would require clang-format to be of a newer version, too! 😀

@ClausKlein
Copy link
Contributor

ClausKlein commented Oct 17, 2024

@TheLartians first off all the CI Must be fixed!

And #41 should be merged 😮

@TheLartians
Copy link
Owner

Sorry, the CI issue should be fixed now if you merge with main. I'm happy with using newer versions of the according formatting tools, but also with adding the suggested flag for scenarios where this is not possible. (also apologies for taking so long to respond, very busy atm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants