Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move to monorepo with bun #4255

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
5d6b464
move library code to package and use bun
KrzysztofMoch Oct 23, 2024
a4465f1
fix installation
KrzysztofMoch Oct 23, 2024
afc6353
fix typescript react resolution
KrzysztofMoch Oct 23, 2024
5db01fb
update bare example config
KrzysztofMoch Oct 23, 2024
ca5b5de
update expo example configuration
KrzysztofMoch Oct 23, 2024
50497c3
remove android & ios folder in expo example
KrzysztofMoch Oct 23, 2024
0f170cd
update examples readme
KrzysztofMoch Oct 23, 2024
6d9972a
allow for workspace postinstall scripts
KrzysztofMoch Oct 23, 2024
c464e34
rename workspace
KrzysztofMoch Oct 23, 2024
91cb5e5
update workflows
KrzysztofMoch Oct 23, 2024
1c20afa
update release-it config
KrzysztofMoch Oct 23, 2024
152dbd2
update android workflow
KrzysztofMoch Oct 23, 2024
24b39f3
fix patch-package script
KrzysztofMoch Oct 24, 2024
e7c52cf
update bun.lockb
KrzysztofMoch Oct 24, 2024
7292a0a
fix clang-check workflow
KrzysztofMoch Oct 24, 2024
866ce40
fix swift lint workflow
KrzysztofMoch Oct 24, 2024
1f76014
chore: update examples README
KrzysztofMoch Nov 8, 2024
5bc2131
bump react-native version in bare example
KrzysztofMoch Nov 11, 2024
48ea883
fix jobs names
KrzysztofMoch Nov 11, 2024
e8d0b92
fix rebase
KrzysztofMoch Nov 26, 2024
a26a94c
fix CI ios builds
KrzysztofMoch Nov 26, 2024
2f6d632
fix expo plugin for internal purposes
KrzysztofMoch Nov 27, 2024
99f197d
fix ads enabling in example on android
KrzysztofMoch Nov 27, 2024
9bd13af
fix expo android example
KrzysztofMoch Dec 4, 2024
9ab989c
fix android example
KrzysztofMoch Dec 14, 2024
38e4b0c
lock bare version to `0.76.4`
KrzysztofMoch Dec 14, 2024
2dd990d
remove bun.lockb
KrzysztofMoch Dec 14, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.lockb binary diff=lockb
34 changes: 0 additions & 34 deletions .github/actions/setup-bun/action.yml

This file was deleted.

34 changes: 0 additions & 34 deletions .github/actions/setup-node/action.yml

This file was deleted.

34 changes: 8 additions & 26 deletions .github/workflows/build-android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ on:
- master
paths:
- '.github/workflows/build-android.yml'
- 'android/**'
- './packages/react-native-video/android/**'
- 'examples/bare/android/**'
- 'yarn.lock'
- 'examples/bare/yarn.lock'
pull_request:
paths:
- '.github/workflows/build-android.yml'
- 'android/**'
- './packages/react-native-video/android/**'
- 'examples/bare/android/**'
- 'yarn.lock'
- 'examples/bare/yarn.lock'
Expand All @@ -32,18 +32,9 @@ jobs:
java-version: 17
java-package: jdk

- name: Install node_modules at Root
uses: ./.github/actions/setup-node
with:
working-directory: ./

- name: Build Library
run: yarn build

- name: Install node_modules at Example
uses: ./.github/actions/setup-node
with:
working-directory: examples/bare
- uses: oven-sh/setup-bun@v2
- name: Install npm dependencies (with bun)
run: bun install

- name: Restore Gradle cache
uses: actions/cache@v4
Expand All @@ -70,18 +61,9 @@ jobs:
java-version: 17
java-package: jdk

- name: Install node_modules at Root
uses: ./.github/actions/setup-node
with:
working-directory: ./

- name: Build Library
run: yarn build

- name: Install node_modules at Example
uses: ./.github/actions/setup-node
with:
working-directory: examples/bare
- uses: oven-sh/setup-bun@v2
- name: Install npm dependencies (with bun)
run: bun install

- name: Restore Gradle cache
uses: actions/cache@v4
Expand Down
145 changes: 56 additions & 89 deletions .github/workflows/build-ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,71 +7,60 @@ on:
- master
paths:
- '.github/workflows/build-ios.yml'
- 'ios/**'
- 'packages/react-native-video/ios/**'
- '*.podspec'
- 'examples/bare/ios/**'
pull_request:
paths:
- '.github/workflows/build-ios.yml'
- 'ios/**'
- 'packages/react-native-video/ios/**'
- '*.podspec'
- 'examples/bare/ios/**'

jobs:
build:
build:
name: Build iOS Example App
runs-on: macos-latest
defaults:
run:
working-directory: examples/bare/ios

steps:
- uses: actions/checkout@v4
- uses: oven-sh/setup-bun@v2

- name: Install node_modules at Root
uses: ./.github/actions/setup-node
with:
working-directory: ./

- name: Build Library
working-directory: ./
run: yarn build

- name: Install node_modules at Example
uses: ./.github/actions/setup-node
with:
working-directory: examples/bare
- name: Install npm dependencies (with bun)
run: bun install

- name: Restore buildcache
uses: mikehardy/buildcache-action@v2
continue-on-error: true

- name: Setup Ruby (bundle)
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.6.10
ruby-version: 2.7.2
bundler-cache: true
working-directory: examples/bare/ios

- name: Install xcpretty
run: gem install xcpretty

- name: Restore Pods cache
uses: actions/cache@v4
with:
path: |
examples/bare/ios/Pods
~/Library/Caches/CocoaPods
~/.cocoapods
key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock') }}
path: examples/bare/ios/Pods
key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock', '**/Gemfile.lock') }}
restore-keys: |
${{ runner.os }}-pods-

- name: Generate Native Project
working-directory: examples/bare/ios
run: pod install

- name: Install Pods
working-directory: examples/bare/ios
run: pod install

- name: Install xcpretty
run: gem install xcpretty

- name: Build App
working-directory: examples/bare/ios
run: "set -o pipefail && xcodebuild \
-derivedDataPath build -UseModernBuildSystem=YES \
-workspace BareExample.xcworkspace \
Expand All @@ -81,62 +70,51 @@ jobs:
-destination 'platform=iOS Simulator,name=iPhone 14' \
build \
CODE_SIGNING_ALLOWED=NO | xcpretty"

build-with-ads:
name: Build iOS Example App With Ads
name: Build iOS Example App with Ads
runs-on: macos-latest
defaults:
run:
working-directory: examples/bare/ios

steps:
- uses: actions/checkout@v4
- uses: oven-sh/setup-bun@v2

- name: Install node_modules at Root
uses: ./.github/actions/setup-node
with:
working-directory: ./

- name: Build Library
working-directory: ./
run: yarn build

- name: Install node_modules at Example
uses: ./.github/actions/setup-node
with:
working-directory: examples/bare
- name: Install npm dependencies (with bun)
run: bun install

- name: Restore buildcache
uses: mikehardy/buildcache-action@v2
continue-on-error: true

- name: Setup Ruby (bundle)
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.6.10
ruby-version: 2.7.2
bundler-cache: true
working-directory: examples/bare/ios

- name: Install xcpretty
run: gem install xcpretty

- name: Restore Pods cache
uses: actions/cache@v4
with:
path: |
examples/bare/ios/Pods
~/Library/Caches/CocoaPods
~/.cocoapods
key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock') }}
path: examples/bare/ios/Pods
key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock', '**/Gemfile.lock') }}
restore-keys: |
${{ runner.os }}-pods-

- name: Generate Native Project
working-directory: examples/bare/ios
run: export RNV_SAMPLE_ENABLE_ADS=true && pod install

- name: Install Pods
run: export RNV_SAMPLE_ENABLE_ADS=true && pod install

- name: Install xcpretty
run: gem install xcpretty
working-directory: examples/bare/ios
run: export RNV_SAMPLE_ENABLE_ADS=true && pod install

- name: Build App
run: "set -o pipefail && export RNV_SAMPLE_ENABLE_ADS=true && xcodebuild \
working-directory: examples/bare/ios
run: "set -o pipefail && xcodebuild \
-derivedDataPath build -UseModernBuildSystem=YES \
-workspace BareExample.xcworkspace \
-scheme BareExample \
Expand All @@ -145,62 +123,51 @@ jobs:
-destination 'platform=iOS Simulator,name=iPhone 14' \
build \
CODE_SIGNING_ALLOWED=NO | xcpretty"

build-with-caching:
name: Build iOS Example App With Caching
build-with-caching:
name: Build iOS Example App with Caching
runs-on: macos-latest
defaults:
run:
working-directory: examples/bare/ios

steps:
- uses: actions/checkout@v4
- uses: oven-sh/setup-bun@v2

- name: Install node_modules at Root
uses: ./.github/actions/setup-node
with:
working-directory: ./

- name: Build Library
working-directory: ./
run: yarn build

- name: Install node_modules at Example
uses: ./.github/actions/setup-node
with:
working-directory: examples/bare
- name: Install npm dependencies (with bun)
run: bun install

- name: Restore buildcache
uses: mikehardy/buildcache-action@v2
continue-on-error: true

- name: Setup Ruby (bundle)
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.6.10
ruby-version: 2.7.2
bundler-cache: true
working-directory: examples/bare/ios

- name: Install xcpretty
run: gem install xcpretty

- name: Restore Pods cache
uses: actions/cache@v4
with:
path: |
examples/bare/ios/Pods
~/Library/Caches/CocoaPods
~/.cocoapods
key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock') }}
path: examples/bare/ios/Pods
key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock', '**/Gemfile.lock') }}
restore-keys: |
${{ runner.os }}-pods-

- name: Generate Native Project
working-directory: examples/bare/ios
run: export RNV_SAMPLE_VIDEO_CACHING=true && pod install

- name: Install Pods
working-directory: examples/bare/ios
run: export RNV_SAMPLE_VIDEO_CACHING=true && pod install

- name: Install xcpretty
run: gem install xcpretty

- name: Build App
run: "set -o pipefail && export RNV_SAMPLE_VIDEO_CACHING=true && xcodebuild \
working-directory: examples/bare/ios
run: "set -o pipefail && xcodebuild \
-derivedDataPath build -UseModernBuildSystem=YES \
-workspace BareExample.xcworkspace \
-scheme BareExample \
Expand Down
Loading
Loading