Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix type in generic folder #4323

Merged
merged 1 commit into from
Jan 4, 2025
Merged

chore: fix type in generic folder #4323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1899,8 +1899,6 @@ public void onCues(CueGroup cueGroup) {
}
}

// ReactExoplayerViewManager public api

public void setSrc(Source source) {
if (source.getUri() != null) {
clearResumePosition();
Expand Down
7 changes: 3 additions & 4 deletions android/src/main/java/com/brentvatne/react/ReactNativeVideoManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package com.brentvatne.react

import com.brentvatne.common.toolbox.DebugLog
import com.brentvatne.exoplayer.ReactExoplayerViewManager

/**
* ReactNativeVideoManager is a singleton class which allows to manipulate / the global state of the app
Expand All @@ -23,13 +22,13 @@ class ReactNativeVideoManager : RNVPlugin {
}
}

private var instanceList: ArrayList<ReactExoplayerViewManager> = ArrayList()
private var instanceList: ArrayList<Any> = ArrayList()
private var pluginList: ArrayList<RNVPlugin> = ArrayList()

/**
* register a new ReactExoplayerViewManager in the managed list
*/
fun registerView(newInstance: ReactExoplayerViewManager) {
fun registerView(newInstance: Any) {
if (instanceList.size > 2) {
DebugLog.d(TAG, "multiple Video displayed ?")
}
Expand All @@ -39,7 +38,7 @@ class ReactNativeVideoManager : RNVPlugin {
/**
* unregister existing ReactExoplayerViewManager in the managed list
*/
fun unregisterView(newInstance: ReactExoplayerViewManager) {
fun unregisterView(newInstance: Any) {
instanceList.remove(newInstance)
}

Expand Down
Loading