Skip to content

Commit

Permalink
yes: deal with UnicodeDecodeError in input(), fixes borgbackup#6984
Browse files Browse the repository at this point in the history
if retry is True, it will just retry to get a valid answer.
if retry is False, it will return the default.

the code can be tested by entering "error" (without the quotes).
  • Loading branch information
ThomasWaldmann committed Dec 29, 2024
1 parent ec3c7b5 commit 9d1107e
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion src/borg/helpers/yes_no.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
TRUISH = ("Yes", "YES", "yes", "Y", "y", "1")
DEFAULTISH = ("Default", "DEFAULT", "default", "D", "d", "")

ERROR = "error"
assert ERROR not in TRUISH + FALSISH + DEFAULTISH


def yes(
msg=None,
Expand Down Expand Up @@ -88,10 +91,14 @@ def output(msg, msg_type, is_prompt=False, **kwargs):
if not prompt:
return default
try:
answer = input()
answer = input() # this may raise UnicodeDecodeError, #6984
if answer == ERROR: # for testing purposes
raise UnicodeDecodeError("?", b"?", 0, 1, "?") # args don't matter
except EOFError:
# avoid defaultish[0], defaultish could be empty
answer = truish[0] if default else falsish[0]
except UnicodeDecodeError:
answer = ERROR
if answer in defaultish:
if default_msg:
output(default_msg, "accepted_default")
Expand Down

0 comments on commit 9d1107e

Please sign in to comment.