Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove example code #5

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Remove example code #5

wants to merge 9 commits into from

Conversation

Ishan1522
Copy link
Member

@Ishan1522 Ishan1522 commented Jan 6, 2025

Removes example code bc is somewhat outdated, incomplete, and we aren’t noobs. Can be viewed in base robot code if people want examples.

@JacksonElia
Copy link
Member

bro pls write a description or a title what does there we goes mean

@Ishan1522
Copy link
Member Author

Bruh so needy

@Ishan1522 Ishan1522 changed the title there we goes Remove example code Jan 6, 2025
Copy link
Member

@JacksonElia JacksonElia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is failing, but once thats fixed lgtm

@Ishan1522
Copy link
Member Author

Ishan1522 commented Jan 8, 2025

build is failing, but once thats fixed lgtm

yeah it'll pass after #3 is merged (and changes are pulled 👍) which will happen after photonlib releases sometime this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants