Fix: Create unconfigured response message #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for exception thrown when attempting to create an ISO response message which doesn't have a header or template in defined in config file. With this fix, we will create a new ISO message with all fields copied, but message type incremented by 16.
|
Made this change as it seemed like this is the intended behavior of CreateResponse as existing code contains logic that will just copy stuff if no config found but this part could never be reached do to exceptions thrown when no config for resulting response message is defined. With this change there should be no exceptions and the consumer will basically receive a copy with type incremented by 16 |
|
@TadijaB Thank you so much for this PR. I will take a look and we can merge it. I appreciate the help. |
|
@TadijaB there is a new release containing your fixes https://www.nuget.org/packages/NetCore8583/2.2.1. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for exception thrown when attempting to create an ISO response message which doesn't have a header or template in defined in config file. With this fix, we will create a new ISO message with all fields copied, but message type incremented by 16.
closes #30