refactor: improve form validation #962
Conversation
customInvalidText, forceCustomError and clearCustomError are deprecated
| get customInvalidText(): string { | ||
| return this._customInvalidText; | ||
| } | ||
|
|
||
| @property({ reflect: true, type: String }) | ||
| error: string = ""; |
There was a problem hiding this comment.
no need to give type, it's already inferred
There was a problem hiding this comment.
I don't think this decorator is trained in TypeScript. It doesn't hurt to have it as an extra, bro.
There was a problem hiding this comment.
it's already inferred as part of TypeScript, no additional work required for decorator. since we don't have explicit types for other values it's better to remove it
| */ | ||
| async forceCustomError() { | ||
| await this.updateComplete; | ||
| this.validationTarget.setCustomValidity(this.customInvalidText || "An error occurred"); | ||
| this.setCustomValidity(this.customInvalidText || "An error occurred"); |
There was a problem hiding this comment.
we have localized text here, either remove it or wrap with localization
There was a problem hiding this comment.
It felt like a different context bro
There was a problem hiding this comment.
it'd be nice to solve it as we caught it, but fine to handle it in a separate pull request.
| @@ -13,31 +13,58 @@ class MyInvalidInput extends LitElement { | |||
| @query("input") | |||
| validationTarget: HTMLInputElement; | |||
|
|
|||
| @property({ reflect: true, type: String }) | |||
| error: string = ""; | |||
There was a problem hiding this comment.
no need to give strict type, already inferred
| validationTarget: HTMLInputElement; | ||
|
|
||
| @property({ reflect: true, type: String }) | ||
| error: string = ""; |
customInvalidText, forceCustomError and clearCustomError are deprecated
add error attribute