Skip to content

Commit

Permalink
Security risk was already fixed by environment protection rules (#1818)
Browse files Browse the repository at this point in the history
Environment protection rules actually made the original version safe, so
remove the comment saying that this condition made it safer

Leaving the condition there, so people don't start accidentally
publishing a website if they fork the repository and enable actions to
format their code
  • Loading branch information
GarboMuffin authored Dec 27, 2024
1 parent fdcd0e4 commit c56ea50
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ jobs:

# If you are forking and want to set up your own website, adjust the repository and branch
# below to match your repository or remove the condition entirely.
# Because we want this workflow to have workflow_dispatch, this is also a security improvement
# as it means extension reviewers can't push a malicious branch then manually deploy it; it
# must go through the master branch and its associated review process.
if: ${{ github.repository == 'TurboWarp/extensions' && github.ref == 'refs/heads/master' }}

steps:
Expand Down

0 comments on commit c56ea50

Please sign in to comment.