JSON extension: v2.6 #1212
JSON extension: v2.6 #1212
Conversation
|
This is perfect! |
|
I have a new update which includes more blocks. |
|
can add export and import lists? |
|
Sure |
|
|
|
@GarboMuffin can you please check if its okay |
|
another 6 months passed |
😭 |
|
@GarboMuffin merge this already 😭😭😭 |
THEN HOW COME ANOTHER VERSION OF THIS EXTENSION WAS MERGED THAT ONLY ADDED THE FIX VALID VALUE THING BUT NOT THIS ONE 😭 |
Yelling at volunteers is not going to merge things faster, this repo is notoriously very slow at merging extensions |
i know i know i know... |
GarboMuffin
added
the
pr: change existing extension
|
We will celebrate the first anniversary of this pull in a month |
|
Please update the pr and fix merge conflicts, cause otherwise this is perfectly fine (at first glance), ill do a more indepth check when its mergable |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
|
@yuri-kiss I think the conflicts are resolved. can you please check again? |
| } | ||
| json = json.trim(); | ||
| if ( | ||
| (json.slice(0, 1) != "[" || json.slice(-1) != "]") && |
There was a problem hiding this comment.
why cant you just do json[0] or json.at(0) and json.at(-1), is there any benifit?, this isnt a review bc im just curious lol
There was a problem hiding this comment.
why did it pop up like a review :(
There was a problem hiding this comment.
There's a conflict from #1596
So I copied the code from there
Perhaps I can change it after this
🤷
misc change
{"key":123}are considered valid json now (leading & trailing spaces)blocks added