CURA-12252 Fix outer wall being translated #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURA-12251 Instead of always reusing the results of the split segments destination, we now calculate them from the initial wall segment, avoiding some rounding errors being accumulated over time and translating the whole path significantly.
nallath
approved these changes
Nov 4, 2024
HellAholic
deleted the
CURA-12251_outer-wall-gets-pushed-away-from-the-inner-wall-when-the-scarf-seam-has-a-high-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always reusing the results of the split segments destination, we now calculate them from the initial wall segment, avoiding some rounding errors being accumulated over time and translating the whole path significantly.
CURA-12251