Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import message doesn't close #177

Closed
hightower5 opened this issue May 14, 2022 · 12 comments · Fixed by #179
Closed

Import message doesn't close #177

hightower5 opened this issue May 14, 2022 · 12 comments · Fixed by #179
Labels
bug Something isn't working

Comments

@hightower5
Copy link

hightower5 commented May 14, 2022

The info window for importing Humble Bundle games does not close automatically.

Screenshot 2022-05-14 120300

@hightower5 hightower5 added the bug Something isn't working label May 14, 2022
@UncleGoogle
Copy link
Owner

Hello, I don't have this problem. Please send some logs to me for - the instruction is written in template of a new issue.

@hightower5
Copy link
Author

plugin-humble-log.zip

@SkebbZ
Copy link

SkebbZ commented May 16, 2022

Same thing here. The plugin's python process also uses max CPU and makes the fans go bananas.
logs.zip

@SkebbZ
Copy link

SkebbZ commented May 16, 2022

I now see that I was stuck at 0.9.5, assuming this is related to #176.
Manually updating to 0.10.0 seems to have created a different problem, however.
Now it connects, then states "connection lost" about three seconds later.

To be clear, the import thing and CPU usage went away with v0.10.0

logs.zip
.

@hightower5
Copy link
Author

@SkebbZ you describe exact my problem.

@UncleGoogle
Copy link
Owner

Ok, so the cookie was invalidated so initialization shoulnd't pass, you should be able to reauthenticate.
Try to click disconnect before "connection lost", then relogin should be fine. I'll try to fix when have time.

@UncleGoogle
Copy link
Owner

UncleGoogle commented May 17, 2022

If you would like to test version that properly handle loosing authentication - close Galaxy, replace one file content in the installed plugin directory - webservice.py - with this: https://github.com/UncleGoogle/galaxy-integration-humblebundle/blob/auth_lost_from_authenticate/src/webservice.py
restart Galaxy

@UncleGoogle
Copy link
Owner

UncleGoogle commented May 17, 2022

@SkebbZ

To be clear, the import thing and CPU usage went away with v0.10.0

thanks for clarification. I don't know why it happen on 0.9.5 thought

One more issue in your logs:

2022-04-08 22:16:16,240 - settings - INFO - Loaded config: {'library': {'sources': ['trove', 'keys', 'drm-free'], 'show_revealed_keys': False}, 'installed': {'search_dirs': ['D:\\Spill']}}
2022-04-08 22:16:16,241 - settings - ERROR - Parsing config error: ValueError("'trove' is not a valid SOURCE")

I'll add systemic fix, but meantime you can clear trove key from file under this path:

LOCAL_CONFIG_FILE = pathlib.Path.home() / "AppData/Local/galaxy-hb/galaxy-humble-config.ini"

@hightower5
Copy link
Author

If you would like to test version that properly handle loosing authentication - close Galaxy, replace one file content in the installed plugin directory - webservice.py - with this: https://github.com/UncleGoogle/galaxy-integration-humblebundle/blob/auth_lost_from_authenticate/src/webservice.py restart Galaxy

I have installed manually version 10.0 and replace 'webservice.py' with the new one. For me, the plugin 10.0 works now.

@SkebbZ
Copy link

SkebbZ commented May 17, 2022

I purged the settings file and set it to "drm-free" only.

It connects properly now, but after connecting the entire GOG client slows to a crawl and uses 100% CPU on the "GalaxyClient
Helper Application". If I terminate that process the GOG client sort of reloads and imports everything normally after a few seconds.

Seems to work OK, until I restart the client. Then it starts to use around 10-12% CPU on the Python process related to the Humble plugin. I know this because when I terminate it, it says "Humble plugin crashed".

logs.zip

Side note:
The entire client was always a bit unstable. Perhaps I just have too many games. If I import my steam account, the entire client crashes or becomes unusable due to having over 4k games there...

At least on Humble I only had 397 drm-free games when I unticked everything else.

@UncleGoogle
Copy link
Owner

It connects properly now, but after connecting the entire GOG client slows to a crawl and uses 100% CPU on the "GalaxyClient
Helper Application". If I terminate that process the GOG client sort of reloads and imports everything normally after a few seconds.

no idea...

Seems to work OK, until I restart the client. Then it starts to use around 10-12% CPU on the Python process related to the Humble plugin. I know this because when I terminate it, it says "Humble plugin crashed".

that's disturbing. Could you set a new issue for that?
is it 12% of the whole available CPU compute power or 12% of the currently used CPU power? Because in the latter case it is quite normal that during the idle, small background processes takes majority of the currently used power.

In the logs I see that all the initial import takes around 1minute. Then - there is nothing interesting - only "pong"'s for galaxy "pings" if the plugin is still alive

@SkebbZ
Copy link

SkebbZ commented May 19, 2022

that's disturbing. Could you set a new issue for that? is it 12% of the whole available CPU compute power or 12% of the currently used CPU power? Because in the latter case it is quite normal that during the idle, small background processes takes majority of the currently used power.

Created a new issue and put a screenshot there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants