Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add authsession cookie valiadation when Galaxy authenticate plugin #179

Merged
merged 2 commits into from
May 26, 2022
Merged

feat: add authsession cookie valiadation when Galaxy authenticate plugin #179

merged 2 commits into from
May 26, 2022

Conversation

UncleGoogle
Copy link
Owner

@UncleGoogle UncleGoogle commented May 16, 2022 •
edited
Loading

Closes #177

todo:

  • add tests for good scenario

@UncleGoogle
Copy link
Owner Author 

"userOptions": {
    "is_logged_in": false,
    "logout_url": "/logout?goto=/&qs="
  },

is_logged_in can be used from humblebundle.com/ webpack content as well to save one request. But seems less reliable

@lgtm-com
Copy link

lgtm-com bot commented May 26, 2022

This pull request introduces 1 alert when merging 96b8eb9 into 52fcb27 - view on LGTM.com

new alerts:

  • 1 for Unused import

@UncleGoogle UncleGoogle merged commit 8e5861e into master May 26, 2022
@UncleGoogle UncleGoogle deleted the auth_lost_from_authenticate branch May 26, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import message doesn't close
1 participant
@UncleGoogle