Fix YYSWF parsing on 2022.1 and beyond #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
VladiStep
requested changes
May 1, 2023
Co-authored-by: VladiStep <[email protected]>
Co-authored-by: VladiStep <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue(s): #1343
Caveats
This assumes that the TPEIndex system is used on 2022.1 and beyond since this is what I had, older GM versions might use TPEIndex too but I don't have enough .wins nor free time to accurately determine this.
Also YYSWF objects are not pooled since they might overlap, i.e. an object might start directly at the parent object's address. If the pool system handles this correctly now, NoPool can be removed.
Notes
YYG if you are reading this please, for god's sake, version your damn changes correctly.